search

neams-th-coe / cardinal

High-Fidelity Multiphysics
https://cardinal.cels.anl.gov/
Other
84 stars 39 forks source link

Minor fix for NekBinnedPlaneIntegral use in non-dimensional cases #882

Open anshchaube opened 2 months ago

anshchaube commented 2 months ago

Small fix that dimensionalises the _gap_width parameter for use with non-dimensional cases. Without it, the volume integral from the bins gets multiplied by L_ref^3, resulting in incorrect scaling for a userobject that should ultimately yield an area (for an appropriate gap_width).

moosebuild commented 2 months ago

Job Precheck on 9ef4fff wanted to post the following:

Your code requires style changes.

A patch was auto generated and copied here
You can directly apply the patch by running, in the top level of your repository:

curl -s https://mooseframework.inl.gov/cardinal/docs/PRs/882/clang_format/style.patch | git apply -v

Alternatively, with your repository up to date and in the top level of your repository:

git clang-format 0d1f9b2a9c57c9b0d69d67fda9b226266e07bf6e

moosebuild commented 2 months ago

Job Documentation on 8b8e8c4 wanted to post the following:

View the site here

This comment will be updated on new commits.