add useful error message for lattice.outer

neams-th-coe / cardinal

High-Fidelity Multiphysics

https://cardinal.cels.anl.gov/

Other

91 stars 45 forks source link

add useful error message for lattice.outer #885

Closed aprilnovak closed 4 months ago

aprilnovak commented 4 months ago

See https://github.com/openmc-dev/openmc/pull/2996

pshriwise commented 4 months ago

Hah, I was going to create an issue for this today. You beat me to it :) I'll review in a bit if that's helpful.

aprilnovak commented 4 months ago

Haha thanks! Yeah your review would be great!

moosebuild commented 4 months ago

Job Documentation on 1641cb3 wanted to post the following:

View the site here

This comment will be updated on new commits.

moosebuild commented 4 months ago

Job Test OpenMC on 60b36a9 : invalidated by @aprilnovak

moosebuild commented 4 months ago

Job Coverage on 1641cb3 wanted to post the following:

Coverage

	a851d7	#885 1641cb
	Total	Total	+/-	New
Rate	93.58%	93.54%	-0.04%	76.47%
Hits	7213	7237	+24	26
Misses	495	500	+5	8

Diff coverage report

Full coverage report

Warnings

New new line coverage rate 76.47% is less than the suggested 90.0%

This comment will be updated on new commits.

aprilnovak commented 4 months ago

Thanks @pshriwise, this looks great! I only made one small change to use the same type of error message for density feedback. Will merge once tests pass

moosebuild commented 4 months ago

Job Precheck on 15477a8 wanted to post the following:

Your code requires style changes.

A patch was auto generated and copied here
You can directly apply the patch by running, in the top level of your repository:

curl -s https://mooseframework.inl.gov/cardinal/docs/PRs/885/clang_format/style.patch | git apply -v

Alternatively, with your repository up to date and in the top level of your repository:

git clang-format a851d7ab521a3221600f2038b65e384b8890a6b0