neams-th-coe / cardinal

High-Fidelity Multiphysics
https://cardinal.cels.anl.gov/
Other
84 stars 39 forks source link

Enforce collision estimator for photon heating. #894

Closed aprilnovak closed 1 month ago

aprilnovak commented 1 month ago

Thanks Shikhar for noting this incompatibility! Photon heating scores cannot be used with tracklength estimators due to some approximations made for thick-target bremmstrahlung.

moosebuild commented 1 month ago

Job Precheck on 4114810 wanted to post the following:

Your code requires style changes.

A patch was auto generated and copied here
You can directly apply the patch by running, in the top level of your repository:

curl -s https://mooseframework.inl.gov/cardinal/docs/PRs/894/clang_format/style.patch | git apply -v

Alternatively, with your repository up to date and in the top level of your repository:

git clang-format f5dc40461febecf38e1a95c146baebafcbf46ab7

moosebuild commented 1 month ago

Job Documentation on d71c58e wanted to post the following:

View the site here

This comment will be updated on new commits.

moosebuild commented 1 month ago

Job Coverage on d71c58e wanted to post the following:

Coverage

f5dc40 #894 d71c58
Total Total +/- New
Rate 93.54% 93.53% -0.01% 93.75%
Hits 7237 7241 +4 15
Misses 500 501 +1 1

Diff coverage report

Full coverage report

This comment will be updated on new commits.

shikhar413 commented 1 month ago

Thanks for the quick patch @aprilnovak!