search

neams-th-coe / cardinal

High-Fidelity Multiphysics
https://cardinal.cels.anl.gov/
Other
91 stars 45 forks source link

Skin displaced mesh #900

Closed meltawila closed 3 months ago

meltawila commented 4 months ago

Update Moab Skinner to use displaced meshes (Ref #899)

moosebuild commented 4 months ago

Job Documentation on ac9a873 wanted to post the following:

View the site here

This comment will be updated on new commits.

aprilnovak commented 4 months ago

Can you remove the MOOSE submodule update you added? I don't think it's necessary. Trying to figure out what the sockeye thing is all about, since I've got another PR which is running the test suite fine...

moosebuild commented 4 months ago

Job Coverage on ac9a873 wanted to post the following:

Coverage

c7ed42 #900 ac9a87
Total Total +/- New
Rate 93.54% 93.54% -0.01% 95.24%
Hits 7245 7252 +7 20
Misses 500 501 +1 1

Diff coverage report

Full coverage report

This comment will be updated on new commits.

aprilnovak commented 3 months ago

For future PRs, make sure to remove any of the deprecated ./ and ../ stuff from input files -- that will eventually no longer be supported, and we're trying to keep Cardinal with latest MOOSE syntax, especially with new file adds.

moosebuild commented 3 months ago

Job Precheck on adbeb4f wanted to post the following:

Your code requires style changes.

A patch was auto generated and copied here
You can directly apply the patch by running, in the top level of your repository:

curl -s https://mooseframework.inl.gov/cardinal/docs/PRs/900/clang_format/style.patch | git apply -v

Alternatively, with your repository up to date and in the top level of your repository:

git clang-format c7ed42c44e3372879079c43b40b691bda22d552f