moosebuild
commented
3 months ago Job Precheck on 4a71080 wanted to post the following:
Your code requires style changes.
A patch was auto generated and copied here
You can directly apply the patch by running, in the top level of your repository:
curl -s https://mooseframework.inl.gov/cardinal/docs/PRs/918/clang_format/style.patch | git apply -v
Alternatively, with your repository up to date and in the top level of your repository:
git clang-format 826aa3f92087079a65ba24f3568a717550f0013d
@AyaHegazy22 noticed that, when filling a triso lattice into multiple cells, each successive set-temperature operation only ended up overwriting whatever temperature had previously been set -- because filling the lattice multiple times does not end up creating unique cell instances.
However, if you first put that triso lattice into a dummy universe, and fill that universe, unique cell instances are created for the contained cells (such that temperature feedback happens correctly).
I've added an error check to Cardinal which will notify if an OpenMC cell already had its temperature set via Cardinal.