Allow the use of mixed CSG-DAGMC models when using the `MOABSkinner`

neams-th-coe / cardinal

High-Fidelity Multiphysics

https://cardinal.cels.anl.gov/

Other

91 stars 45 forks source link

Allow the use of mixed CSG-DAGMC models when using the `MOABSkinner` #957

Open nuclearkevin opened 2 weeks ago

nuclearkevin commented 2 weeks ago

This PR allows for the use of mixed geometry models (CSG + DAGMC) when skinning with the MOABSkinner, with a few caveats:

CSG cells cannot be mapped to the MOOSE mesh mirror when using a skinner. This is to prevent the generation of erroneous DAGMC geometry which may overlap with pre-existing CSG geometry in the OpenMC model. This restriction will be relaxed in a future PR by modifying the MOABSkinner.
The OpenMC geometry can only contain a single DAGMC universe, otherwise the universe to overwrite with skinned geometry cannot be automatically detected.
The DAGMC universe can only be contained within a single CSG cell, and that cell must exist exclusively in the root universe. This avoids the duplication of DAGMC geometry as this duplicated geometry may not be skinned. Similarly, the DAGMC geometry is not allowed in lattices when using a MOABSkinner.

moosebuild commented 2 weeks ago

Job Documentation on 07bdc8c wanted to post the following:

View the site here

This comment will be updated on new commits.

nuclearkevin commented 2 weeks ago

Found some undefined behaviour when re-initializing the CSG geometry. Marking this PR as a draft until I figure out what's going on and resolve the issue.

moosebuild commented 2 weeks ago

Job Precheck on 41c587e wanted to post the following:

Your code requires style changes.

A patch was auto generated and copied here
You can directly apply the patch by running, in the top level of your repository:

curl -s https://mooseframework.inl.gov/cardinal/docs/PRs/957/clang_format/style.patch | git apply -v

Alternatively, with your repository up to date and in the top level of your repository:

git clang-format fed9f014545dfab6dd7ff2218144f6556c7b2b67

moosebuild commented 1 week ago

Job Documentation, step Sync to remote on 0d3fb72 wanted to post the following:

View the site here

This comment will be updated on new commits.

aprilnovak commented 1 week ago

@meltawila can you try rebasing your branch off this one? It occurred to me that this might be a fix for the multigroup temperature loading issue. With this PR, you can now have some CSG cells floating super far away from your CAD slab, and in those CSG cells you can set their temperature from the XML to span the range of the benchmark