Fix lyrics look-ahead logic - Githubissues

neanes / neanes

Neanes is a free and open source scorewriter for notating Byzantine chant in Byzantine notation.

https://neanes.github.io/neanes/

GNU General Public License v3.0

35 stars 9 forks source link

Fix lyrics look-ahead logic #669

Closed danielgarthur closed 3 weeks ago

danielgarthur commented 3 weeks ago

Amends #660, which appears to be missing a break; statement. This caused the nextNote to be always the last note. After:

Before:

basil commented 3 weeks ago

Thank you Daniel and sorry for the trouble. Although I did test that other PR against every Neanes score I have, I didn't have any scores that triggered this specific failure mode. I guess that underscores the need to develop an open-source test suite for this software. I have been trying to do my part to develop such a thing over at https://github.com/basil/byzantine-music.