neanes / neanes

Neanes is a free and open source scorewriter for notating Byzantine chant in Byzantine notation.
https://neanes.github.io/neanes/
GNU General Public License v3.0
35 stars 9 forks source link

[ENHANCEMENT] Fthora limitations lifted #80

Closed sudop0wer closed 1 year ago

sudop0wer commented 1 year ago

Is your feature request related to a problem? Please describe. Yes. I was transcribinng a sheet that had a Zygos fthora on Zo, and the rules of the fthora didn't allow me to introduce it, so I had to place manually attractions.

Describe the solution you'd like I think it would be best to select if you want fthora rules to apply to a sheet, or not.

Describe alternatives you've considered Eliminating the rules at all, though they may be useful for someone who doesn't know them and is writing sheets

Additional context None

danielgarthur commented 1 year ago

Giving the users the option to disable the normal fthora rules is an option, but my concern is the calculation of martyria. This came up in #48, too. If chroa are allowed anywhere, then it's not always clear what the correct martyria should be when placed in non-standard locations.

While it's unlikely that a martyria will appear while the chroa is in effect, it could happen. One option could be to allow users in this case to create their own custom martyria by selecting whatever root sign they want.

sudop0wer commented 1 year ago

This is a romanian theory book that I read and it's accurate in all other matters. About Zygos fthora it says that it changes the martyria below it to Necheanes (as the one from chromatic Pa), and the one above it no Nana (as from normal Ga). All other martyrias are kept the same. The book says this for Ke, but specifies that it is available for all other notes. It may be a solution, if you want to consider it. Allowing the user to choose the martyria he wants is another. InkedWhatsApp Image 2023-04-01 at 20 33 54

PsaltyDog commented 1 year ago

Allowing the user to choose the martyria he wants is another.

Or maybe even just force the user to choose the martyria if he's using a fthora in a non-standard way?

danielgarthur commented 1 year ago

The option to disable fthora restrictions has been added to 0.3.0-beta.16.

Go to Page Setup and check the "Disable Fthora Restrictions" checkbox.

image

All restrictions will be lifted. Audio playback may not properly playback the correct scales if fthores are in non-standard positions.

image

If you want to change the root sign on a martyria, you can use the "Root Sign Override" dropdown in the bottom martyria toolbar. In this screenshot I have changed the root sign to Varys to demonstrate the feature.

image