Closed deniciocode closed 9 months ago
Hi there! I'm also a Rubyist and prefer the pink that it is now, personally. If you'd like to have the highlight be changed on your personal copy, you can use the configuration settings:
require("everforest").setup({
on_highlights = function (hl, palette)
hl.TSSymbol = { link = "Aqua" }
end
})
Hey @neanias, I understand your personal
preference. IMO the default color for symbols should be used. From the original Repo it is Agua
.
Not wishing to be overly pedantic, but in the original, TSSymbol
is linked to Fg
: https://github.com/sainnhe/everforest/blob/72f101bd63228a1a45012325e39c5280ec22c828/colors/everforest.vim#L533.
Either way, the point of my personal preference being for pink as opposed to keeping it in line with the original repo is vaild and I'm happy to set it back to match the original repo and add my own stylings locally.
@neanias I am fine with pendantic
I understand the point and thanks for highlighting the line of code out. The original repo does not really work with tree sitter, this is the reason I found this repo here to have full color support.
When ruby is not installed for tree-sitter the the symbols are in Agua
. When ruby is installed on tree-sitter the colors for the symbols are gone.
I am not sure if we should change to non colored symbols. It looks more like a lack of tree-sitter support. Here is an example for the color for non tree-sitter https://github.com/sainnhe/everforest/blob/72f101bd63228a1a45012325e39c5280ec22c828/colors/everforest.vim#L2522
Are you opening a new PR? Happy to accept your changes
@neanias I messed something up and needed to readd the changes. Sorry for the confusion. All conflicts are gone and it is ready to be merged
@neanias I am not able to merge these changes
Many thanks for adding that!
This small change will use
Agua
for symbols. Coding in ruby and having a lot of symbols makes the look of the color pink unpleasant IMO. Here is the look and feel in a screen short. Left are symbols inPink
and on the right are the symbols inAgua