neanias / everforest-nvim

A Lua port of the Everforest colour scheme
233 stars 15 forks source link

[Feature request] Improved Svelte support #17

Closed mjholub closed 8 months ago

mjholub commented 8 months ago

I really like that this colorscheme is capable of highlighting <style> blocks in Svelte, but in <script> section, comments or literals are not handled too well. See screenshot. image

neanias commented 8 months ago

Hi! What would you like the comments to look like? The treesitter parser for Svelte tags those comments as @comment.javascript, so it'll be using the @comment styles

mjholub commented 8 months ago

yeah same as in js is fine

neanias commented 8 months ago

That's what I'm saying: it's already the same as JS as far as I can tell. Does this same snippet look different if you put it in a JS file (e.g. foo.js)? (Or TS?)

mjholub commented 8 months ago

see here

code inside <script> should be highlighted the same or similar way as it is on the right image

mjholub commented 8 months ago

OK I tried with other colorschemes and the issue persists. Using :set ft=html seems to mostly resolve the issue. I'll open an issue at tree-sitter-svelte.