TrevorJTClarke
commented
2 years ago This is an amazing effort, but I feel like it adds a lot of complexity, the scripts are hard to grasp and more complicated than they should be.
Instead, I think it would be more useful to show commands examples: how to add a transfer proposal/how to create an account etc and let the user decide what flow they want to test.
This PR is for setting up reproducibility for upgrades. The idea is to have:
- dev script: quick commands you, me & anyone (like auditors) else can quickly uncomment for spot testing
- testnet script: a stable, full script that goes from current state to fully upgraded state contracts, so there i no guessing or making mistakes in commands.
- mainnet script: a stable, full script that goes from current state to fully upgraded state contracts, same as testnet but even more careful attention to reproducible results.
Thanks for feedback on the scripts themselves, let's keep this setup going and move toward only using scripts for the upgrade process rather than comment/examples. It will help reproducible results & maintainability. Upgrade is scary, scripts will keep us sane :)
This is an amazing effort, but I feel like it adds a lot of complexity, the scripts are hard to grasp and more complicated than they should be.
Instead, I think it would be more useful to show commands examples: how to add a transfer proposal/how to create an account etc and let the user decide what flow they want to test.