near-daos / sputnik-dao-contract

Smart contracts for https://app.astrodao.com
https://astrodao.com/
MIT License
108 stars 76 forks source link

Fix backwards compatibility issue on get_staking_contract #129

Closed ctindogaru closed 2 years ago

ctindogaru commented 2 years ago

This was introduced in https://github.com/near-daos/sputnik-dao-contract/pull/38.

Previously, the method was returning '' when there was no staking contract set up. Now, the method is returning null which will cause backwards compatibility issues.

This PR aims to switch the logic back to how it was previously and return an empty string.

TrevorJTClarke commented 2 years ago

Great catch - thanks!