search

near-daos / sputnik-dao-contract

Smart contracts for https://app.astrodao.com
https://astrodao.com/
MIT License
108 stars 77 forks source link

Actions on several proposals #73

Closed fedencer closed 2 years ago

AngelBlock commented 2 years ago

Thanks a lot for your contribution!

Minor suggestions.

Thanks for your input @ctindogaru , we get to it immediately.

TrevorJTClarke commented 2 years ago

@fedencer mind taking a minute to resolve latest conflicts?

ctindogaru commented 2 years ago

Under what circumstances would you need batch actions on proposal?

ctindogaru commented 2 years ago

I have a few concerns with this PR:

AngelBlock commented 2 years ago

I have a few concerns with this PR:

  • it complicates the current logic by a lot
  • it might introduce some nasty bugs: one example is: if someone has the last approval on a transfer proposal and sends a batch action with 3 approves on the same proposal, that receiver might actually get funded 3 times. This needs to be checked tho.

If this complicates the logic and opens to potential exploits, lets just cancel it altogether and I will be able to script it from frontend.

AngelBlock commented 2 years ago

Under what circumstances would you need batch actions on proposal?

There are DAOs which council need to vote for many proposals at the time, at the moment they use multiple devices to speed it up, for example 100 at the time - is quite challenging.

ctindogaru commented 2 years ago

I have a few concerns with this PR:

  • it complicates the current logic by a lot
  • it might introduce some nasty bugs: one example is: if someone has the last approval on a transfer proposal and sends a batch action with 3 approves on the same proposal, that receiver might actually get funded 3 times. This needs to be checked tho.

If this complicates the logic and opens to potential exploits, lets just cancel it altogether and I will be able to script it from frontend.

If you can do that, it would be ideal @AngelBlock!

AngelBlock commented 2 years ago

Parking of closing for reasons specified in the discussion thread.