Closed fedencer closed 2 years ago
@fedencer mind taking a minute to resolve latest conflicts?
Under what circumstances would you need batch actions on proposal?
I have a few concerns with this PR:
I have a few concerns with this PR:
- it complicates the current logic by a lot
- it might introduce some nasty bugs: one example is: if someone has the last approval on a transfer proposal and sends a batch action with 3 approves on the same proposal, that receiver might actually get funded 3 times. This needs to be checked tho.
If this complicates the logic and opens to potential exploits, lets just cancel it altogether and I will be able to script it from frontend.
Under what circumstances would you need batch actions on proposal?
There are DAOs which council need to vote for many proposals at the time, at the moment they use multiple devices to speed it up, for example 100 at the time - is quite challenging.
I have a few concerns with this PR:
- it complicates the current logic by a lot
- it might introduce some nasty bugs: one example is: if someone has the last approval on a transfer proposal and sends a batch action with 3 approves on the same proposal, that receiver might actually get funded 3 times. This needs to be checked tho.
If this complicates the logic and opens to potential exploits, lets just cancel it altogether and I will be able to script it from frontend.
If you can do that, it would be ideal @AngelBlock!
Parking of closing for reasons specified in the discussion thread.
Thanks for your input @ctindogaru , we get to it immediately.