search

near-daos / sputnik-dao-contract

Smart contracts for https://app.astrodao.com
https://astrodao.com/
MIT License
108 stars 77 forks source link

Remove duplicated validation on staking id #79

Closed ctindogaru closed 2 years ago

ctindogaru commented 2 years ago

Remove unnecessary overhead. The validation already happens here: https://github.com/near-daos/sputnik-dao-contract/blob/main/sputnikdao2/src/proposals.rs#L442-L445

ctindogaru commented 2 years ago

Closing this as I've just realised that if you're creating 2 SetStakingContract proposals simultaneously, approve the first one and then approve the second one, the second one will succeed although it should not since the staking id has already been set in the first one.