Closed norrec99 closed 3 years ago
The page looks very good I think. I have a few comments: 1- The margin related to the image maybe you can check that maybe it's correct but in the video, it looks a bit far. 2- I think the text over the image is not necessary. 3- The text on the right we can git the GitHub bio as we did we the image. 4- The colors maybe can be changed to NEAR green and shadow can be a bit less because it's taking too much from the image. 5- I think it was nice to change the en to English and the tr to Turkish. we do something like if en return English.
6- As Anuj suggested I think the videos made by the contributor are nice to show. maybe we can make it like a slider. like this there are libraries that can help :
We don't have to do everything at once maybe we can make the slider in different PR as a different issue for sure also.
Tried to implement some changes according to your feedback. I installed the moment js library to display the video's timestamp in a nice way, so you need to yarn install after this pr merged. It becomes a huge pr, sorry about that. Next time, I try to make smaller prs
Closing this pr because of #53
Hey there, I created a new page for /authors/:id When you click the github images, it directs you to authors/:id page. I will record a loom video below to explain details. Don't forget to give some feedback.