search

near-in-minutes / frontend

NEAR in Minutes is a NEAR-COOP (NEAR Community Owned and Operated Project) that invites you to binge-watch lessons about the NEAR platform in your favorite language.
https://near-in-minutes.com
0 stars 0 forks source link

login to near #36

Closed hiba-machfej closed 3 years ago

hiba-machfej commented 3 years ago
Screen Shot 2021-07-01 at 12 32 32 PM Screen Shot 2021-07-01 at 12 32 56 PM
hiba-machfej commented 3 years ago

@norrec99 @ozanisgor @BigDaddy-Zephyr

norrec99 commented 3 years ago

Awesome job hiba. Looks very nice. I only have one question, do we need a login with near feature on this website? If so, what should users do when they login with near?

hiba-machfej commented 3 years ago

Awesome job hiba. Looks very nice. I only have one question, do we need a login with near feature on this website? If so, what should users do when they login with near?

we don't actually need it right now, but in the future maybe. It's not necessary right now. But if people will get rewards we need some sort of authentication and what is better than NEAR.

hiba-machfej commented 3 years ago

We don't have to merge the PR now actually.

hiba-machfej commented 3 years ago

@amgando @norrec99 @BigDaddy-Zephyr @ozanisgor should I re-do the login and add it as a feature? I think it will be useful for future updates when we start giving people bounties.

amgando commented 3 years ago

@hiba-machfej this would make sense if we're tracking NEAR accounts and correlating them with activity on the site. that's not happening yet so this feature, for me, would be confusing -- why am I logging in, I would wonder?

hiba-machfej commented 3 years ago

@hiba-machfej this would make sense if we're tracking NEAR accounts and correlating them with activity on the site. that's not happening yet so this feature, for me, would be confusing -- why am I logging in, I would wonder?

I agree with you the logging in is not required for now. So, I'll close the PR for now.