search

near-in-minutes / frontend

NEAR in Minutes is a NEAR-COOP (NEAR Community Owned and Operated Project) that invites you to binge-watch lessons about the NEAR platform in your favorite language.
https://near-in-minutes.com
0 stars 0 forks source link

Fix: Text color were not visible #61

Closed norrec99 closed 3 years ago

norrec99 commented 3 years ago

added white background and opacity font weight increased

render[bot] commented 3 years ago

Your Render PR Server URL is https://near-in-minutes-com-pr-61.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c3ldrrs7o9q7tesggtag.

norrec99 commented 3 years ago

Regarding this issue #57

hiba-machfej commented 3 years ago

This closes #57

amgando commented 3 years ago

@norrec99 i would guess that since the author image is darkened, that a dark background stripe for these details with white text would be easier to read. have you tried this? i added a screenshot of the current version to compare with an updated version if you make the change.

notice in this picture you have to kind of strain your eyes to see "MainNet" (or at least I do 😉 )

image

norrec99 commented 3 years ago

@amgando you are totally right. I've tried that and it looks like this;

Because of the opacity its parent has, the white color looks grayish. To minimize that, I increased the opacity from 50 to 70 in this example. Let me know if this looks better.

amgando commented 3 years ago

@norrec99 this looks find but your commit includes a bunch of edits to quotes, for example, that have nothing to do with the commit. we should agree on linting standards but in the meantime can you remove these parts of the commit please?

you should be able to do this easily using interactive staging documented here: https://git-scm.com/book/en/v2/Git-Tools-Interactive-Staging

hiba-machfej commented 3 years ago

@norrec99 can we work on closing the PR, please?

norrec99 commented 3 years ago

I tried to change double quotes to single quotes.

Also, the background is now black and the text is white. (easier to read)

humanman commented 3 years ago

I tried to change double quotes to single quotes.

Also, the background is now black and the text is white. (easier to read)

I think the changes are great, they just need to be split into 2 separate commits. So revert 250dad9 since it's out of scope of Text color were not visible. Then create a new PR for 250dad9 which has to do with the quotes. Does that make sense?

norrec99 commented 3 years ago

Ben and I worked on this branch to split the commits. For now, it has double quotes but I will create another branch just to convert all double quotes to single quotes.