search

near-in-minutes / frontend

NEAR in Minutes is a NEAR-COOP (NEAR Community Owned and Operated Project) that invites you to binge-watch lessons about the NEAR platform in your favorite language.
https://near-in-minutes.com
0 stars 0 forks source link

Create node.js.yml #73

Closed hiba-machfej closed 3 years ago

hiba-machfej commented 3 years ago

This is related to #72. It will create an action and check if the PR follows the style guide. I also added a rule that we can't merge to the main branch unless two reviews have accepted the changes.

Screen Shot 2021-07-27 at 1 07 05 PM
render[bot] commented 3 years ago

Your Render PR Server URL is https://near-in-minutes-com-pr-73.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c3vtpt9g7hp1ulqcp1p0.

hiba-machfej commented 3 years ago

The check will fail I think because yarn fix is not yet implemented which is in the previous PR #72

humanman commented 3 years ago

The check will fail I think because yarn fix is not yet implemented which is in the previous PR #72

yarn doesn't have a fix command, so you'll have to use npm audit fix or install something like yarn-audit-fix - https://www.npmjs.com/package/yarn-audit-fix or look for other alternatives https://stackoverflow.com/questions/40057469/what-is-the-difference-between-yarn-lock-and-npms-shrinkwrap

hiba-machfej commented 3 years ago

The check will fail I think because yarn fix is not yet implemented which is in the previous PR #72

yarn doesn't have a fix command, so you'll have to use npm audit fix or install something like yarn-audit-fix - https://www.npmjs.com/package/yarn-audit-fix or look for other alternatives https://stackoverflow.com/questions/40057469/what-is-the-difference-between-yarn-lock-and-npms-shrinkwrap

That's weird because I tried it locally in the other branch where i added yarn fix and it worked. In here it is not available so it won't work. I also tried it in a test repo before I added it to NiM: https://github.com/hiba-machfej/prettier-guestbook/pull/11

humanman commented 3 years ago

That's weird because I tried it locally in the other branch where i added yarn fix and it worked. In here it is not available so it won't work. I also tried it in a test repo before I added it to NiM: hiba-machfej/prettier-guestbook#11

That is very weird, because you should have seen error Command "fix" not found. in the terminal. You can see from the yarn docs that fix isn't a recognized command. My only guess is that there's a yarn cli package you may have installed globally that does in fact make use of a yarn fix command

hiba-machfej commented 3 years ago

That's weird because I tried it locally in the other branch where i added yarn fix and it worked. In here it is not available so it won't work. I also tried it in a test repo before I added it to NiM: hiba-machfej/prettier-guestbook#11

That is very weird, because you should have seen error Command "fix" not found. in the terminal. You can see from the yarn docs that fix isn't a recognized command. My only guess is that there's a yarn cli package you may have installed globally that does in fact make use of a yarn fix command

yes in this PR I can see the error you are telling me about as the checks have failed and it's not available in the package.

But in this PR https://github.com/near-in-minutes/frontend/pull/72 . If you check the branch added-rules locally and run yarn fix and it works normally.

Screen Shot 2021-07-27 at 5 39 00 PM
humanman commented 3 years ago

@hiba-machfej aha! check the package.json in the added-rules branch - specifically last item in scripts section.

hiba-machfej commented 3 years ago

@hiba-machfej aha! check the package.json in the added-rules branch - specifically last item in scripts section.

:D ah yes it won't work if it's not added to the package. I guess we were talking about the same thing but I misunderstood you.