search

near-in-minutes / frontend

NEAR in Minutes is a NEAR-COOP (NEAR Community Owned and Operated Project) that invites you to binge-watch lessons about the NEAR platform in your favorite language.
https://near-in-minutes.com
0 stars 0 forks source link

feat(tracking): add google analytics #89

Closed oceanByte closed 3 years ago

oceanByte commented 3 years ago

We are still testing this feature. Please ignore this until you are added as a reviewer.

render[bot] commented 3 years ago

Your Render PR Server URL is https://near-in-minutes-com-pr-89.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c48httk6fj33r8n539qg.

oceanByte commented 3 years ago

I think I need your help here @hiba-machfej. We are missing the GOOGLE_ANAYLTICS id. It seems like it is not getting it from the environment variables that you created in render.com. Visit https://near-in-minutes-com-pr-89.onrender.com and check the console logs. It says "Missing the "id" parameter. Add at least one tracking domain ID".

Do you need to set up the environments for each branch individually?

hiba-machfej commented 3 years ago

I think I need your help here @hiba-machfej. We are missing the GOOGLE_ANAYLTICS id. It seems like it is not getting it from the environment variables that you created in render.com. Visit https://near-in-minutes-com-pr-89.onrender.com and check the console logs. It says "Missing the "id" parameter. Add at least one tracking domain ID".

Do you need to set up the environments for each branch individually?

yes, it looks like you said. Each branch needs its own environment variable. I added it now let's see.

hiba-machfej commented 3 years ago

it is still giving the error after I add it to the branch.

hiba-machfej commented 3 years ago

@oceanByte I changed the name from GOOGLE_ANALYTICS to VUE_APP_GOOGLE_ANALYTICS and it's working now.

oceanByte commented 3 years ago

This could be merged now once reviewed.

We need to implement a cookie banner as well to be compliant. @hiba-machfej do you want to take care of this in a separate branch? Have a look here: https://www.npmjs.com/package/vue-cookie-law

hiba-machfej commented 3 years ago

This could be merged now once reviewed.

We need to implement a cookie banner as well to be compliant. @hiba-machfej do you want to take care of this in a separate branch? Have a look here: https://www.npmjs.com/package/vue-cookie-law

yes sure. thank you for your help with this.

hiba-machfej commented 3 years ago

This could be merged now once reviewed.

We need to implement a cookie banner as well to be compliant. @hiba-machfej do you want to take care of this in a separate branch? Have a look here: https://www.npmjs.com/package/vue-cookie-law

This library seems to support only vue 2 only. https://github.com/apertureless/vue-cookie-law/issues/72

I tried to find a vue 3 library but I could not find one. Can you recommend another one? or is it ok if I create a modal with the same text as the library ?

oceanByte commented 3 years ago

I tried to find a vue 3 library but I could not find one. Can you recommend another one? or is it ok if I create a modal with the same text as the library ?

It seems like there are no similar popular libraries for vue3 yet. Have you tried if it works anyway? Otherwise, I think you need to create your own banner. This is a little time consuming, but in the end, you can just copy the style and functionality from the suggested library.

If you have the time, you could consider adding vue3 support to the mentioned library. It seems like the community is interested in this as well. But this might be a more complicated task.

hiba-machfej commented 3 years ago

I tried to find a vue 3 library but I could not find one. Can you recommend another one? or is it ok if I create a modal with the same text as the library ?

It seems like there are no similar popular libraries for vue3 yet. Have you tried if it works anyway? Otherwise, I think you need to create your own banner. This is a little time consuming, but in the end, you can just copy the style and functionality from the suggested library.

If you have the time, you could consider adding vue3 support to the mentioned library. It seems like the community is interested in this as well. But this might be a more complicated task.

Yes I tried to use the library and it did not work. I guess I'll have to create the banner for NiM.

It would be nice to develop vue3 support to the mentioned library but I've never done anything like that, I am not sure how is it done.