near / account-lookup

Temporary tool for account / lockup lookup
http://near.github.io/account-lookup/
1 stars 5 forks source link

wip: fix total lockup balance #20

Closed telezhnaya closed 2 years ago

telezhnaya commented 2 years ago

Story we have an account https://explorer.near.org/accounts/opgran01.near we checked the info for this account at the moment 31 dec 2020 (block_height 26490580) the script told us this account had 40 tokens as the owner and 35 tokens on the lockup but in reality, the lockup had huge amount of money and we have the TX about it https://explorer.near.org/transactions/3db8TpxEu1kSB4v4mPRBCqHsBBna8Zfq2Jkvf67A4CVs

@frol could you please check this fix carefully? I have no idea how it's possible that we still have an error here. I did my best in fixing that but I still doubt whether it's fine

telezhnaya commented 2 years ago

fyi, I used this branch to debug this, you may find it useful https://github.com/near/account-lookup/commit/9ffd4c48b583dfb345f34ec98a75be2130d99255 (always prefer to play with console instead of browser)

frol commented 2 years ago

@telezhnaya All the tokens were transferred to the owner account since that initial transfer to the lockup contract: https://explorer.near.org/transactions/9bw5bvmDGG2CkqgKhC51Yz2rLPLFCwSJXSWgGgsCYvZe#7hyM3yPVs1X8SJmhpYHj2ADmdtuM1rG4etUboH3adDd2

I feel the currently deployed code is displaying the current state of things correctly. The lockup was immediately unlocked on mainnet launch and the funds were withdrawn.

telezhnaya commented 2 years ago

Tokens were transferred on January 12th 2021 (the tx you attached), while the tool was ignoring them on December 31st 2020. There is a bug

telezhnaya commented 2 years ago

Closing this; opening it as an issue; it requires more investigation