search

near / borsh

Binary Object Representation Serializer for Hashing
https://borsh.io/
487 stars 41 forks source link

contract compilation fails due to borsh update #82

Open amgando opened 4 years ago

amgando commented 4 years ago

https://travis-ci.com/github/near/create-near-app/jobs/356517030#L670-L709

Compiling status-message v0.1.0 (/home/travis/build/near/create-near-app/tmp-project/contract)
error[E0277]: the trait bound `Welcome: borsh::de::BorshDeserialize` is not satisfied

while dependabot is trying to bump borsh from 0.6.2 to 0.7.0 in github/near/create-near-app/common/contracts/rust

not sure what to do about this

bowenwang1996 commented 4 years ago

We need to reexport dependency from near-sdk-rs to avoid this https://github.com/near/near-sdk-rs/issues/164

chadoh commented 4 years ago

@bowenwang1996 does this mean we should wait for a newer version of borsh and skip the 0.7.0 update?

bowenwang1996 commented 4 years ago

It's related to near-sdk-rs version, not borsh version. Looks like it should be fixed now with near-sdk-rs version 1.0.0

chadoh commented 4 years ago

For reference, here's how I fixed this for create-near-app https://github.com/near/create-near-app/pull/408