Closed robertlopezdev closed 4 months ago
awesome! I have been hoping for an improvement sweep like this to take place
One regression that was not accounted for in unit tests: in config files, the property expected is now
account_id
instead ofaccount
You can reproduce by running with
cargo run -- -c
in thetest
dir
Did not catch that, thanks.
I made a commit to update this and to update the README to reflect the change as well.
awesome! I have been hoping for an improvement sweep like this to take place One regression that was not accounted for in unit tests: in config files, the property expected is now
account_id
instead ofaccount
You can reproduce by running withcargo run -- -c
in thetest
dirDid not catch that, thanks.
I made a commit to update this and to update the README to reflect the change as well.
Sorry for not making this clearer: since this is a tool that is already widely used, we should resolve the regression and continue looking for account
in the config file instead of changing to account_id
there. Otherwise we are shipping a breaking change to users without good reason
awesome! I have been hoping for an improvement sweep like this to take place One regression that was not accounted for in unit tests: in config files, the property expected is now
account_id
instead ofaccount
You can reproduce by running withcargo run -- -c
in thetest
dirDid not catch that, thanks. I made a commit to update this and to update the README to reflect the change as well.
Sorry for not making this clearer: since this is a tool that is already widely used, we should resolve the regression and continue looking for
account
in the config file instead of changing toaccount_id
there. Otherwise we are shipping a breaking change to users without good reason
Gotcha, reverted back to account
.
thanks for you contribution @robertlopezdev !
Hello,
During a recent discussion this repo was mentioned, so I explored refactoring. The key changes include:
tokio
for more efficient processing of large directories of React component files.anyhow
crate for better error handling.I have ensured that all unit tests pass and that the output from the
test/components
is consistent with the original version's output.This refactor introduces dependencies on
anyhow
andasync_recursion
to facilitate the transition to async. If these additions are a concern, I am open to discussing alternatives or reverting to the initial synchronous rewrite I committed, which still offers improved error messaging, syntax and some cleaning up of un-needed cloning.Open to any discussions or requests for changes. Looking forward to your thoughts!
Best regards,
Robert Lopez