near / cargo-near

Cargo extension for building Rust smart contracts on NEAR
Apache License 2.0
34 stars 17 forks source link

feat: correct .github workflows from `new` command to work with docker case #193

Closed dj8yfo closed 2 months ago

dj8yfo commented 3 months ago

@race-of-sloths include

race-of-sloths commented 3 months ago

@dj8yfo Thank you for your contribution! Your pull request is now a part of the Race of Sloths! Do you want to apply for monthly streak? Get 8+ score for a single PR this month and receive boost for race-of-sloths!

[

<source media="(prefers-color-scheme: light)" srcset="https://badge.race-of-sloths.com/dj8yfo?type=bot&theme=light">
<img alt="Shows profile picture for the author of the PR" src="https://badge.race-of-sloths.com/dj8yfo?type=bot&theme=white">

](https://race-of-sloths.com/profile/dj8yfo)

Current status: executed | Reviewer | Score | |--------|--------| | @frol | 8 | Your contribution is much appreciated with a final score of 8! You have received 84 (80 base + 5% lifetime bonus) Sloth points for this contribution
What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow For contributors: - Tag @race-of-sloths inside your pull requests - Wait for the maintainer to review and score your pull request - Check out your position in the [Leaderboard](https://race-of-sloths.com/leaderboard) - Keep weekly and monthly streaks to reach higher positions - Boast your contributions with a dynamic picture of your [Profile](https://race-of-sloths.com/profile/dj8yfo) For maintainers: - Score pull requests that participate in the Race of Sloths - Engage contributors with fair scoring and fast responses so they keep their streaks - Promote the Race to the point where the Race starts promoting you - Grow the community of your contributors Feel free to check [our website](https://race-of-sloths.com) for additional details!

Bot commands - For contributors - **Include a PR:** `@race-of-sloths include` to enter the Race with your PR - For maintainers: - **Assign points:** `@race-of-sloths score [1/2/3/5/8/13]` to award points based on your assessment. - **Reject this PR:** `@race-of-sloths exclude` to send this PR back to the drawing board. - **Exclude repo:** `@race-of-sloths pause` to stop bot activity in this repo until `@race-of-sloths unpause` command is called
dj8yfo commented 2 months ago

staging ci fails from workflow https://github.com/dj8yfo/workflows_test/blob/failing_ci_staging/.github/workflows/deploy-staging.yml#L38-L55

staging ci passes from workflow https://github.com/dj8yfo/workflows_test/blob/passing_ci_staging/.github/workflows/deploy-staging.yml#L48-L60

dj8yfo commented 2 months ago

output of diff -r old/.github/workflows new/.github/workflows (new is cargo new project from pr, old is cargo new project from latest 0.8.2 release)

diff --color -r old/.github/workflows/deploy-production.yml new/.github/workflows/deploy-production.yml
18c18
<         run: curl --proto '=https' --tlsv1.2 -LsSf https://github.com/near/cargo-near/releases/download/cargo-near-v0.6.2/cargo-near-installer.sh | sh
---
>         run: curl --proto '=https' --tlsv1.2 -LsSf https://github.com/near/cargo-near/releases/download/cargo-near-v0.8.2/cargo-near-installer.sh | sh
diff --color -r old/.github/workflows/deploy-staging.yml new/.github/workflows/deploy-staging.yml
37c37
<         run: curl --proto '=https' --tlsv1.2 -LsSf https://github.com/near/cargo-near/releases/download/cargo-near-v0.6.2/cargo-near-installer.sh | sh
---
>         run: curl --proto '=https' --tlsv1.2 -LsSf https://github.com/near/cargo-near/releases/download/cargo-near-v0.8.2/cargo-near-installer.sh | sh
38a39,42
>         # `--skip-git-remote-check` was used
>         # as pull request git refs `refs/pull/NUMBER/merge` are somewhat harder to access and live only as long as PRs do
>         # 
>         # WASM reproducibility check akin to SourceScan won't be available for staging contracts, deployed from PRs 
40c44
<           cargo near deploy "${{ env.NEAR_CONTRACT_PR_STAGING_ACCOUNT_ID }}" \
---
>           cargo near deploy --skip-git-remote-check "${{ env.NEAR_CONTRACT_PR_STAGING_ACCOUNT_ID }}" \