search

near / corgis

simple solution for corgi NFT
22 stars 16 forks source link

package.json file had to be modified + install parcel on Windows to run corgis #10

Open AnaisUrlichs opened 4 years ago

AnaisUrlichs commented 4 years ago

Not sure if this is a Windows issue or general but I had to install parcel

npm install parcel-bundler --save-dev

and modify the package.json with the following "babel": { "presets": [ [ "@babel/preset-env", { "targets": { "browsers": [ "last 2 Chrome versions" ] }, "exclude": [ "transform-regenerator" ] } ], "@babel/preset-react" ], "plugins": [ [ "@babel/plugin-proposal-class-properties" ], [ "@babel/transform-runtime" ] ] },

Otherwise, I received several errors.

mikedotexe commented 4 years ago

hey @AnaisUrlichs I did not experience a problem like this. I see that parcel-bundler has been added as a devDependency here: https://github.com/nearprotocol/corgis/blame/master/package.json#L43

AnaisUrlichs commented 4 years ago

Hmm, well even better I guess. What about the babel changes?

mikedotexe commented 4 years ago

I didn't have any issue with babel either on Windows, weird.

On Wed, Jul 8, 2020 at 11:33 PM AnaisUrlichs notifications@github.com wrote:

Hmm, well even better I guess. What about the babel changes?

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/nearprotocol/corgis/issues/10#issuecomment-655930232, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAH6R23N47GGPMP2GHW7A3DR2VQBXANCNFSM4OUPIPYA .

AnaisUrlichs commented 4 years ago

Ok, thank you for checking, I will take it out of the commit then. Just wondering if others will run into a similar issue.

AnaisUrlichs commented 4 years ago

I got the same errors running corgis on Ubuntu as on Windows corgierror

Fixed it by following this https://github.com/parcel-bundler/parcel/issues/1762 and the documentation to modify the package.json file https://babeljs.io/docs/en/babel-plugin-transform-runtime