near / fast-auth-signer

https://fast-auth-signer.vercel.app
MIT License
29 stars 8 forks source link

Initialize Firestore on App.tsx #176

Open Pessina opened 4 months ago

vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fast-auth-signer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 12, 2024 8:59am
hcho112 commented 4 months ago

I have pulled this PR locally and conducted a test with following condition:

  1. Use current main branch on fast-auth-signer
  2. Sign in with existing account on Chrome browser
  3. Sign out
  4. Check out to current branch
  5. Attempt to sign in

I see this error message:

image

Maybe we need to look into further?

hcho112 commented 4 months ago

above error is occurred from https://github.com/near/fast-auth-signer/blob/main/packages/near-fast-auth-signer/src/lib/controller.ts#L293

Maybe if user fail at this point, we send them email verification here? (eg, it would make sense to re-verify here because if expected oidc is absent, first thing we should do is email verification)