near / fast-auth-signer

https://fast-auth-signer.vercel.app
MIT License
29 stars 8 forks source link

URL encoding issue on Login #195

Open Pessina opened 3 months ago

Pessina commented 3 months ago

The email parameter in the URL is being double-encoded on line 57 of Login.tsx (https://github.com/near/fast-auth-signer/blob/d7fb38aa8bfad5cb2528dc38641da2206e73258b/packages/near-fast-auth-signer/src/components/Login/Login.tsx#L57).

A previous fix by @hcho112 to handle special characters in emails like "test+1@gmail.com" introduced this issue. Now, emails like "felipe@near.org" are incorrectly returned as "felipe%40near.org".

Demo video bellow:

https://github.com/near/fast-auth-signer/assets/22358004/a17a23a5-b120-46f6-8c9a-7def9978a5ed