search

near / fast-auth-signer

https://fast-auth-signer.vercel.app
MIT License
29 stars 8 forks source link

Replacing hardcode RPC URLs with environment variables #248

Closed hcho112 closed 2 weeks ago

hcho112 commented 3 weeks ago

This PR contains implementation to replace hardcoded URL to environment variables.

243

vercel[bot] commented 3 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fast-auth-signer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 18, 2024 1:34am
hcho112 commented 3 weeks ago

I wasn't sure if we need to also support receiving provider URL via query param. @Pessina let me know what do you think?

Pessina commented 3 weeks ago

@hcho112 , thanks for the improvement!

I think that's a good start. In the future, we can allow the caller to pass them as arguments when calling SignMultiChain.

If they provide arguments, we use the provided ones; otherwise, we fall back to the default values.