near / mpc

30 stars 6 forks source link

fix: possible deadlock in load triple #595

Closed ppca closed 1 month ago

ppca commented 1 month ago

Issue: Node state never advanced from Starting to Started. I observe the logs where "loading triples using datastore" were printed 3 times, but not seeing "loading triples success" or "triple load failed." message being printed.

Resolution: I'm not able to find exactly what went wrong, I know state advancing was stuck at loading triples. I deleted all triples in datastore, then the node state start advancing.

Possible cause: I looked through the code for async fn load_triples(), I'm not able to figure out why "loading triples using datastore" were printed 3 times, but not seeing "loading triples success" or "triple load failed." message being printed. I know we had some schema incompatibility issue, and possible deadlocking, but I'm not sure if they indicate no success or failure messages.

this PR: address the potential deadlock issue

github-actions[bot] commented 1 month ago

Terraform Feature Environment Destroy (dev-595)

Terraform Initialization ⚙️success

Terraform Destroy success

Show Destroy Plan ``` No changes. No objects need to be destroyed. Either you have not created any objects yet or the existing objects were already deleted outside of Terraform. Destroy complete! Resources: 0 destroyed. ```

Pusher: @ppca, Action: pull_request, Working Directory: `, Workflow:Terraform Feature Env (Destroy)`