near / mpc

37 stars 11 forks source link

fix: store reshared key after generation #615

Closed ppca closed 4 months ago

ppca commented 4 months ago

We did not store the new key share to secret manager previously, so whenever restart, we don't have the correct key share for the epoch anymore

ChaoticTempest commented 4 months ago

wow, nice catch on this. Can we also add in a test (or maybe add it to already existing reshare test) to check on whether or not after resharing, we were able to store this secret value?

ppca commented 4 months ago

wow, nice catch on this. Can we also add in a test (or maybe add it to already existing reshare test) to check on whether or not after resharing, we were able to store this secret value?

Yep we can do that. Thanks to now we have the local disk storage secret storage option. :D

github-actions[bot] commented 4 months ago

Terraform Feature Environment Destroy (dev-615)

Terraform Initialization ⚙️success

Terraform Destroy success

Show Destroy Plan ``` No changes. No objects need to be destroyed. Either you have not created any objects yet or the existing objects were already deleted outside of Terraform. Destroy complete! Resources: 0 destroyed. ```

Pusher: @ChaoticTempest, Action: pull_request, Working Directory: `, Workflow:Terraform Feature Env (Destroy)`