github-actions[bot]
commented
3 months ago Terraform Feature Environment Destroy (dev-636)
Terraform Initialization ⚙️success
Terraform Destroy success
Show Destroy Plan
``` No changes. No objects need to be destroyed. Either you have not created any objects yet or the existing objects were already deleted outside of Terraform. Destroy complete! Resources: 0 destroyed. ```Pusher: @ChaoticTempest, Action: pull_request, Working Directory: `, Workflow:Terraform Feature Env (Destroy)`
Noticed that indexer can potentially fail but won't report the error until we go to join the handle much later. This is due to the fact that panics are per thread here and would require getting the panic hook to truly handle it. Which is quite a hassle to deal with for now.
There's one minor thing this doesn't address is the cancellation of threads, which means that the when we go to join the thread handle at the end of the run call, it will potentially not join due to indexer being alive still. We would need to add some cancellation mechanisms such as sending over a message to kill the indexer loop, but that's too much work right now for this simple fix.