near / mpc

37 stars 11 forks source link

fix: clear triples after reshare #638

Closed ChaoticTempest closed 3 months ago

ChaoticTempest commented 3 months ago

We were not clearing our triples from datastore after a reshare, which is required due to there being new participants and potentially older ones no longer existing. The old set of triples would for the most part not be valid and should just cleared. We were already clearing them from memory when we construct a new TripleManager.

Also bins message on TripleIsMissing since that's the case where the node does not have the triple at all due to datastore corruption or was never observed in the system. We won't be able to go into a state where the triple is found so just delete the message.

This can be made more clear with a partitioning of where triples are stored https://github.com/near/mpc/issues/637. Which would allow us to serve signatures beyond the resharing phase if we'd like not to clear triples and maintain a separate network for a bit

github-actions[bot] commented 3 months ago

Terraform Feature Environment Destroy (dev-638)

Terraform Initialization ⚙️success

Terraform Destroy success

Show Destroy Plan ``` No changes. No objects need to be destroyed. Either you have not created any objects yet or the existing objects were already deleted outside of Terraform. Destroy complete! Resources: 0 destroyed. ```

Pusher: @ChaoticTempest, Action: pull_request, Working Directory: `, Workflow:Terraform Feature Env (Destroy)`