github-actions[bot]
commented
3 months ago Terraform Feature Environment Destroy (dev-648)
Terraform Initialization ⚙️success
Terraform Destroy success
Show Destroy Plan
``` No changes. No objects need to be destroyed. Either you have not created any objects yet or the existing objects were already deleted outside of Terraform. Destroy complete! Resources: 0 destroyed. ```Pusher: @ppca, Action: pull_request, Working Directory: `, Workflow:Terraform Feature Env (Destroy)`
Has been broken since we change folder structure. already tested on develop this works. This will fix the down dev env.
There were 2 bugs with the Dockerfile.multichain: 1) we copied whole mpc folder instead of
chain-signatures/folder. the issue there is the top level mpc folder has noCargo.tomlfile, nothing will be built; 2) after fixing 1), I find that https://github.com/near/mpc/blob/develop/chain-signatures/.cargo/config.toml#L2 actually ask to put the built binary to../target, instead oftarget. But later when we doCOPY --from=builder /usr/src/app/target/release/mpc-recovery-node /usr/local/bin/mpc-recovery-nodeit is copying fromtargetinstead of../target. Which will copy nothingThis can be verified by built artifact size. If you look at artifacts size: correct ones are 60+mb, incorrect ones are only 50+ mb. I think reflects the fact that actually nothing is built.
Also included a dependency fix. Because the dmd/bump-dependencies branch has been deleted, I updated to a commit hash that merged.