near / near-cli-rs

near CLI is your human-friendly companion that helps to interact with NEAR Protocol from command line.
https://near.cli.rs
Apache License 2.0
102 stars 56 forks source link

bugfix: fixed parsing account id for fetching active staking pools #369

Closed akorchyn closed 4 months ago

akorchyn commented 4 months ago

What was wrong

The provided string contained a data prefix before the account id name that prevented the function from parsing the AccountId Also, I extracted the filter into the call itself See image: image

@race-of-sloths

race-of-sloths commented 4 months ago

@akorchyn Thank you for your contribution! Your pull request is now a part of the Race of Sloths! You are true leader! Other sloths hot on your heels, keep moving!

[

<source media="(prefers-color-scheme: light)" srcset="https://badge.race-of-sloths.com/akorchyn?type=bot&theme=light">
<img alt="Shows profile picture for the author of the PR" src="https://badge.race-of-sloths.com/akorchyn?type=bot&theme=white">

](https://race-of-sloths.com/profile/akorchyn)

Current status: executed | Reviewer | Score | |--------|--------| | @frol | 3 | **The average score is 3** @akorchyn check out your results on the [Race of Sloths Leaderboard!](https://race-of-sloths.com/leaderboard) and in the [profile](https://race-of-sloths.com/profile/akorchyn)
What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow For contributors: - Tag @race-of-sloths inside your pull requests - Wait for the maintainer to review and score your pull request - Check out your position in the [Leaderboard](https://race-of-sloths.com/leaderboard) - Keep weekly and monthly streaks to reach higher positions - Boast your contributions with a dynamic picture of your [Profile](https://race-of-sloths.com/profile/akorchyn) For maintainers: - Score pull requests that participate in the Race of Sloths - Engage contributors with fair scoring and fast responses so they keep their streaks - Promote the Race to the point where the Race starts promoting you - Grow the community of your contributors Feel free to check [our website](https://race-of-sloths.com) for additional details!

Bot commands - For contributors - **Include a PR:** `@race-of-sloths include` to enter the Race with your PR - For maintainers: - **Assign points:** `@race-of-sloths score [1/2/3/5/8/13]` to award points based on your assessment. - **Reject this PR:** `@race-of-sloths exclude` to send this PR back to the drawing board. - **Exclude repo:** `@race-of-sloths pause` to stop bot activity in this repo until `@race-of-sloths unpause` command is called
frol commented 4 months ago

@race-of-sloths score 3

race-of-sloths commented 4 months ago

🌟 Score recorded!

@frol, thank you for scoring this pull request in the Race of Sloths!

race-of-sloths commented 4 months ago

✅ PR is finalized!

Your contribution is much appreciated with a final score of 3! You have received 50 (30 base + 20 weekly bonus) Sloth points for this contribution

Another weekly streak completed, well done @akorchyn! To keep your weekly streak and get another bonus make pull request next week! Looking forward to see you in race-of-sloths