near / near-cli

General purpose command line tools for interacting with NEAR Protocol
https://docs.near.org
MIT License
193 stars 93 forks source link

Fixing generate-key with --seedPhrase #1003

Open mm-near opened 2 years ago

mm-near commented 2 years ago

Currently when you call

near --generate-key --seedPhrase a b c ..

It will create 2 implicit keys (one with the seedPhrase and the other one with random value) - which is a little bit confusing.

Moreover, I think that something's wrong with seed-phrase.js code - as it should probably store the key in a seedPhraseKeystore (but I'm not very familiar with this code).

volovyks commented 2 years ago

@judith-Near can you please fix tests, since they are broken on master after your last merge.