near / near-cli

General purpose command line tools for interacting with NEAR Protocol
https://docs.near.org
MIT License
193 stars 93 forks source link

create-account's default value for --initialBalance is extremely high #1004

Closed charleslavon closed 7 months ago

charleslavon commented 2 years ago

initialBalance is an optional param of significant consequence when it is omitted, a consequence of 100N https://github.com/near/near-cli/blob/4b4a787d0eafaa97fb7c2c741cdfaacf2c53f35b/commands/create-account.js#L34-L38

Recommendation: initialBalance should be a required parameter

willemneal commented 2 years ago

Currently a lot of tests depend on this default, which while not the reason to keep it, is the reason it hasn't changed.

See https://github.com/near/near-cli/pull/991

frol commented 2 years ago

I want to mention that there is a similar issue #238

gagdiez commented 7 months ago

the value has been changed to 1N by default.