search

near / near-cli

General purpose command line tools for interacting with NEAR Protocol
https://docs.near.org
MIT License
193 stars 91 forks source link

fix: generate-key-using-seed-phrase #1036

Closed hanakannzashi closed 1 year ago

hanakannzashi commented 1 year ago

fix issue #949

think-in-universe commented 1 year ago

The fix make sense to me. @volovyks

volovyks commented 1 year ago

Thank you @hanakannzashi ! It would be great to add a simple test for this change. And in general, we need to turn on tests from external contributors in this repo. cc @ailisp I think it should be a standard for all repos where we expect contributions, I suppose, all tooling repos.

Related issue: https://github.com/near/workspaces-js/pull/200 For some reason I was not able to turn this feature on there.

hanakannzashi commented 1 year ago

Thank you @hanakannzashi ! It would be great to add a simple test for this change. And in general, we need to turn on tests from external contributors in this repo. cc @ailisp I think it should be a standard for all repos where we expect contributions, I suppose, all tooling repos.

Related issue: near/workspaces-js#200 For some reason I was not able to turn this feature on there.

This PR still has some issue, I will close it later. I am not particularly clear about the purpose of MergeKeyStore in this project. The code of generate-key.js is very strange, I think there are many issues in this file. Also, I can't unstand the code on seed-phrase.js