near / near-cli

General purpose command line tools for interacting with NEAR Protocol
https://docs.near.org
MIT License
193 stars 93 forks source link

chore: Remove requirement for specifying accountId for js view #983

Closed ChaoticTempest closed 2 years ago

ChaoticTempest commented 2 years ago

this forces people to specify the signer for near js view, so removed the requirement and have the signer be whatever. This isn't really even signing anything, just an oddity of near-api-js requiring an account-id to create an account, to then make a view call

volovyks commented 2 years ago

Same situation as in https://github.com/near/near-cli/pull/984

ChaoticTempest commented 2 years ago

this one's a little different, since this is due to NAJ requiring an accountId/account object to send a view function call. Specifying the accountId here isn't needed at all in the CLI so making it optional to not create a breaking change