search

near / near-cli

General purpose command line tools for interacting with NEAR Protocol
https://docs.near.org
MIT License
193 stars 93 forks source link

lower account creation initial balance from 100 to 10 #991

Closed thisisjoshford closed 2 years ago

thisisjoshford commented 2 years ago

Fixes #990

volovyks commented 2 years ago

It will be a breaking change for a lot of scripts that are relying on this amount. I would rather not merge it. Isn't it better to increase the number of tokens in the original acc from 200 to ~1000?

thisisjoshford commented 2 years ago

It will be a breaking change for a lot of scripts that are relying on this amount. I would rather not merge it. Isn't it better to increase the number of tokens in the original acc from 200 to ~1000?

Ahhhh... I didn't realize this would be a breaking change with those using scripts. (Should have ran the tests in this repo before submitting the PR 🤦🏼‍♂️ ) I thought this would be a simple easy fix but if its introducing complications lets just close this PR @volovyk-s.

willemneal commented 2 years ago

I still don't understand why this couldn't be a major bump then. I assume those are test scripts that could be updated to use the newer version. From a devx perspective it's a weird default.

thisisjoshford commented 2 years ago

I still don't understand why this couldn't be a major bump then. I assume those are test scripts that could be updated to use the newer version. From a devx perspective it's a weird default.

Yeah, I do agree that 100 seems to be a weird default and yeah... most likely these scripts are tests that will need to be updated for users. Thoughts @volovyk-s ?

Isn't it better to increase the number of tokens in the original acc from 200 to ~1000?

I think if we did this the faucets would get depleted very quickly as some write scripts to create a dev-account then delete it and grab the 200 $NEAR. We did have the default set to 500 $NEAR and then lowered it... I think it was because someone was draining testnet faucets but not sure how lowering it by 300 resolved the issue. Let me see if I can dig up the reasoning of lowering initial balance of dev-accounts / testnet accounts.

MaximusHaximus commented 2 years ago

FYI, testnet account creation that doesn't use a masterAccount to fund the account (e.g. the dev-deploy command, which only works on testnet) would not be impacted by this change, because testnet account creation is provided by a REST API call to the near-contract-helper, which ignores any value you provide and always gives every account the same 200N on creation. Changing the default would only impact creation on mainnet and on testnet using a masterAccount.

FYI, re: 'faucets', the NEAR that are given to new dev-deploy created accounts are provided from the balance held by the testnet top-level account, which has a balance currently of over 55 million NEAR (https://explorer.testnet.near.org/accounts/testnet).

It is not clear to me whether, how, and/or how often the testnet account gets additional balance added to it, but if it is never increased, then using 200N per account, we could create around ~275,000 dev-deploy accounts before exhausting the current balance of the testnet account. Is that something you are investigating already @thisisjoshford ?