search

near / near-discovery-components

This is a repository that holds the source code of all NEAR discovery components that the team maintains for near.org.
https://near.org
MIT License
14 stars 12 forks source link

chore: cleanup of Post related components #783

Closed shelegdmitriy closed 6 months ago

shelegdmitriy commented 6 months ago

This PR introduces a couple of cleanups of Post related components. As a part of this cleanup, I removed defining of fetchGraphQL method in order to use VM.require() for exact the same method:

const { fetchGraphQL } = VM.require("${REPL_ACCOUNT}/widget/Entities.QueryApi.Client");
gabehamilton commented 6 months ago

Looking good!

shelegdmitriy commented 6 months ago

@charleslavon seems like there is an issue with IndexFeed as I mentioned in the description. That's why this PR partirly solves that linked issue. I'm not sure we are planning to spend some time on refactoring the IndexFeed component. Maybe it's worth to created a separate task with description and maybe some contributor will take a look at it.

charleslavon commented 6 months ago

Thanks for the detail @shelegdmitriy. Yes please create an issue to track whatever delta remains after this PR. What difference will this PR make?

shelegdmitriy commented 6 months ago

Thanks for the detail @shelegdmitriy. Yes please create an issue to track whatever delta remains after this PR. What difference will this PR make?

Changes the upload limit of posts per page (from 10 to 5)