Correctly display Borsh arguments in contract calls

near / near-explorer

NEAR blockchain explorer

https://explorer.near.org/

Apache License 2.0

87 stars 55 forks source link

Correctly display Borsh arguments in contract calls #202

Open kcole16 opened 4 years ago

kcole16 commented 4 years ago

See https://app.zenhub.com/workspaces/chainmiddleware-5cea2bcf78297c385cf0ec81/issues/nearprotocol/nearcore/2167

Story

As a user, I want to view the arguments of a contract call in a readable format whether they are in JSON or Borsh.

Acceptance Criteria

[ ] For functionCall actions, arguments are displayed in readable format in TX detail page /transaction/<txHash>

kcole16 commented 4 years ago

@vgrichina Does it make more sense to handle Borsh directly in Explorer, or to use a nearlib helper function? And do we still think hexdump is the way to go? https://www.npmjs.com/package/hexdump-nodejs

frol commented 4 years ago

FYI, hexdump is already implemented since #183

kcole16 commented 4 years ago

FYI, hexdump is already implemented since #183

Awesome!

In that case, what are the remaining TODOs here?

frol commented 4 years ago

Well, we still don't display borsh-serialized arguments, but they are not yet properly implemented AFAIK, so there are no actionable items here right now.