search

near / near-explorer

NEAR blockchain explorer
https://explorer.near.org/
Apache License 2.0
86 stars 53 forks source link

Max TPS display #361

Open MaksymZavershynskyi opened 4 years ago

MaksymZavershynskyi commented 4 years ago

We need to have some service on standby that would periodically, e.g. once a day, run short benchmarks on our testnet, e.g. to determine max transfer and contract call TPS, and we would display this number in explorer. The intent of this service to have several blocks saturated with transactions, if the service observes that we already have such blocks within 1 day window then it would do nothing.

ilblackdragon commented 4 years ago

Why is this explorers job though? It can be a separate app doing that?

MaksymZavershynskyi commented 4 years ago

Then we need to clarify what goes into explorer's scope. In my mind explorer has the same scope of responsibility as https://etherscan.io/

frol commented 4 years ago

We used to display Max TPS, but decided to hide it as it was not useful.

However, on the general note, I am not 100% sure about using Explorer as a status monitoring tool. Graphana seems to be a more appropriate tool.

MaksymZavershynskyi commented 4 years ago

AFAIR, one of the reasons max TPS was removed from the explorer is because it was not showing the correct max TPS due to quirks of implementation. If we see explorer as an alternative to https://etherscan.io/ https://etherscan.io/ which is a development tool then contract developers expect some basic metrics to be in it. Let’s move discussion here: https://github.com/near/near-explorer/issues/367 https://github.com/near/near-explorer/issues/367

On Jul 24, 2020, at 6:04 AM, Vlad Frolov notifications@github.com wrote:

We used to display Max TPS, but decided to hide it as it was not useful.

However, on the general note, I am not 100% sure about using Explorer as a status monitoring tool. Graphana seems to be a more appropriate tool.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/near/near-explorer/issues/361#issuecomment-663527676, or unsubscribe https://github.com/notifications/unsubscribe-auth/AILKVBZHOETLI66BP4OTDIDR5GBELANCNFSM4PC5GFVQ.

ilblackdragon commented 4 years ago

@nearmax To be specific, Max TPS is meaningless metric. It really depends on type of transaction, and on Ethereum our bridge transactions for example will be only 10 per block (0.83 tps?) vs payments prob closer to 20+ based on gas.

I'm all for explorer to have features of etherscan, but where in etherscan do you see max tps though? And definitely etherscan doesn't have a script to benchmark the networks to get that max tps there - hence that sounds like outside of the scope for explorer.

I'm all for having these charts though - https://etherscan.io/charts if we want to open up bounties for them.