Wildcard module declaration

luixo commented 2 years ago

Story

As a newcomer to this repository, I'm pretty confused with declaration declare module "*" in typescript extraneous declaration file. It seems like a smelly code for me, combining with no monorepo tooling it caused an irritating bug of every module being linked to this declaration, effectively ruining all type checks.

Seems like this line was added to help out with absent type on datamaps module, but probably it was an overkill to add a wildcard for that.

Proposals

Replace wildcard module definition to datamaps module definition
Either update datamaps to 0.5.9 which has type definitions and write own react components or make a PR with types to react-datamaps package (propose your own solution!)
Be more strict on wildcards in general :)

frol commented 2 years ago

Given that the GeoMap Page is now dead, we may as well just remove datamaps for now.

Well, there were some historical reasons why I went stupid and merged the PR before we addressed all the code quality issues. We should definitely improve it.

@luixo If this breaks your productivity, I suggest you address this issue first.

luixo commented 2 years ago

Given that the GeoMap Page is now dead, we may as well just remove datamaps for now.

Should we remove it completely? You can still access it via direct link.

Upd: it's been commented out for a half a year now

frol commented 2 years ago

Yes, go ahead and remove it completely

near / near-explorer

Wildcard module declaration #802

Story

Proposals