search

near / near-indexer-for-explorer

Watch NEAR network and store all the data from NEAR blockchain to PostgreSQL database
https://near-indexers.io/docs/projects/near-indexer-for-explorer
GNU General Public License v3.0
123 stars 56 forks source link

feat: add new change reason kind MIGRATION #121

Closed telezhnaya closed 3 years ago

telezhnaya commented 3 years ago

Fixes #111

telezhnaya commented 3 years ago

It's great, but also we need to extend corresponding enum and adjust it's impl :)

I am sorry for that 😞 I forgot to search for ids in camelCase in the project.

Also I expect tests to fail after you made this change, because it's in newer commit than release one, so you can take latest master commit for now, we will include it in later release

Don't worry about that. If we merge this one earlier, I will rebase the release commit, so the order will be OK.

khorolets commented 3 years ago

Don't worry about that. If we merge this one earlier, I will rebase the release commit, so the order will be OK.

We will postpone merging, will create a release based on #120 and after that will merge this, because this is a preparation to 1.20.0 nearcore release.

khorolets commented 3 years ago

@telezhnaya could you please run cargo fmt?

telezhnaya commented 3 years ago

could you please run cargo fmt?

@khorolets It finished silently with no editions, code is clean 👌

khorolets commented 3 years ago

It finished silently with no editions, code is clean 👌

my bad, I've misread the build error, sorry :)