near / near-indexer-for-explorer

Watch NEAR network and store all the data from NEAR blockchain to PostgreSQL database
https://near-indexers.io/docs/projects/near-indexer-for-explorer
GNU General Public License v3.0
123 stars 56 forks source link

Inconsistent error messages #369

Open WuTao18 opened 1 year ago

WuTao18 commented 1 year ago

In the store_action_receipts function located in near-indexer-for-explorer/database/src/adapters/receipts.rs, the error_message in await_retry_or_panic! is "Failed to store ReceiptActions in database", but in other functions, the error_message is "Something were stored in database" (1, 2, 3, 4).

telezhnaya commented 1 year ago

Hey @WuTao18! I agree, sometimes we have a mess in our log messages. The phrasing is also not the best. If you have time, could you please help us with this?

WuTao18 commented 1 year ago

Hey @WuTao18! I agree, sometimes we have a mess in our log messages. The phrasing is also not the best. If you have time, could you please help us with this?

Sure, I'm glad to provide help.

khorolets commented 1 year ago

@WuTao18 I've assigned this issue to you since you're volunteering to help. It's just a mark for us that someone (in your happy case, you) is working on it.

Thank you for all your contributions! 🙏