search

near / near-jsonrpc-client-rs

Lower-level API for interfacing with the NEAR Protocol via JSONRPC.
https://docs.rs/near-jsonrpc-client
Apache License 2.0
47 stars 41 forks source link

feat: add wait_until flag, drop check_tx method #136

Closed telezhnaya closed 6 months ago

telezhnaya commented 9 months ago

Updated the code to match with 1.37 nearcore release https://github.com/near/nearcore/blob/447572bb775a5954ca7a5a4b65c85b45aab9e499/chain/jsonrpc/CHANGELOG.md#023 TLDR:

We need to merge it only after 1.37 will be released

telezhnaya commented 9 months ago

The only failing test fails because it really sends RPC request to mainnet which is not upgraded yet (so, the method does not work as we expect).

telezhnaya commented 9 months ago

Updated. As before, one of the tests fails because mainnet and testnet still has 1.36, waiting for the release

khorolets commented 8 months ago

I am curious about the best approach to releasing this soon. With the ReadRPC project, we are working on a version compatible with 1.37.x nearcore that is already run on testnet. We use near-jsonrpc-client-rs heavily and would like to run on the released version rather than fork.

And for the future, we'd like to be able to use newer versions of the client before the nearcore update on the mainnet. Do you think we can adjust the release process of this crate somehow?

cc @frol @telezhnaya @kobayurii

khorolets commented 8 months ago

Update:

We've agreed with the change on the nearcore release process to enable release candidates (RC) for the nearcore's workspace crates. Since the next testnet release we expect to have all the crates like near-jsonrpc-primitives, near-primitives and others to be released with the same *-rc.{\d} as nearcore.

The mainnet 1.37.0 release is anticipated this week, so we're not getting the necessary crates beforehand this time, but the next time it should be available 🎉

frol commented 7 months ago

Status update: blocked on https://near.zulipchat.com/#narrow/stream/295302-general/topic/publishing.20nearcore.20crates/near/425971002

jaswinder6991 commented 6 months ago

Are there any new changes needed here other than just running the CI again? I can help if anything, we needed this merged for a project.

frol commented 6 months ago

I will re-open this PR to trigger CI

jaswinder6991 commented 6 months ago

Thanks Vlad, I can see that doc tests failed again. I made a PR to wait_until branch to fix this. https://github.com/near/near-jsonrpc-client-rs/pull/139

As an aside, I see that you fixed it a month ago as well. Does the archival node only keep a months old data? or is it failing because of some other reason. Would it be a good idea to change the test somehow rather than fixing it every month (not a big deal though but still)