near / near-sdk-rs

Rust library for writing NEAR smart contracts
https://near-sdk.io
Apache License 2.0
466 stars 249 forks source link

Look into merging trait definitions and macro code together. #1123

Open ruseinov opened 11 months ago

ruseinov commented 11 months ago

For everything that is defined in near-sdk-macros/src/core_impl/code_generator. Perhaps a good approach could be to introduce a code_generator module for each trait in their respective modules.

_Originally posted by @frol in https://github.com/near/near-sdk-rs/pull/1118#discussion_r1430714235_

frol commented 3 months ago

On second thought, someone would need to look into the project structure and make a call on what would be the best way to resolve this structuring puzzle. I think it does not require deep NEAR understanding, so I mark this issue as good-first-issue for someone to potentially play around it, but it is not a high-priority issue by any means.

ruseinov commented 3 months ago

Sounds good! Let's see if someone wants to attack this.

IjayAbby commented 3 months ago

Hey @ruseinov can I give it a shot see what I can come up with?

IjayAbby commented 3 months ago

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

I have an understanding in both Rust and Python and would love to stretch out my rust skills a bit. Am not familiar with NEAR but I can work around it.

How I plan on tackling this issue

Work closely with the project maintainer to see how best I can resolve the issue with existing ideas in place. Would love to give it a shot.

frol commented 3 months ago

@IjayAbby Sure, give it a try