near / near-sdk-rs

Rust library for writing NEAR smart contracts
https://near-sdk.io
Apache License 2.0
442 stars 227 forks source link

Some examples are not tested properly #1190

Open Sliman4 opened 1 month ago

Sliman4 commented 1 month ago

Just cloned the repo, tried to follow CONTRIBUTING.md, here's what I noticed:

frol commented 1 month ago

@Sliman4 Would you be open to addressing these? I am happy to review and merge PRs

Sliman4 commented 1 month ago

Some examples seem to be intentionally removed from gh actions (not sure why, but I guess there was a good reason), and I believe ci-test.sh is not referenced from anywhere, unless I don't understand something. I think it would be better if it was done by someone with more knowledge about CI, and specifically workflows of this repo, as I don't feel confident that I understand how and what is supposed to be tested, and don't have time to go through relevant commits, issues, and PRs