Open Sliman4 opened 1 month ago
@Sliman4 Would you be open to addressing these? I am happy to review and merge PRs
Some examples seem to be intentionally removed from gh actions (not sure why, but I guess there was a good reason), and I believe ci-test.sh
is not referenced from anywhere, unless I don't understand something. I think it would be better if it was done by someone with more knowledge about CI, and specifically workflows of this repo, as I don't feel confident that I understand how and what is supposed to be tested, and don't have time to go through relevant commits, issues, and PRs
Just cloned the repo, tried to follow
CONTRIBUTING.md
, here's what I noticed:./run-tests.sh
, it doesn't work because examples .wasm files are not built yet, and there's no notice that you should runexamples/build_all.sh
beforehand. Not sure what's the best way to fix it, since there is abuild_all_docker.sh
that may or may not be used in some cases.examples/non-fungible-token
fails to build tests because it doesn't useunit-testing
feature of SDK, andexamples/versioned
has the same problem + uses deprecatedUnorderedMap
.