search

near / near-wallet

Web wallet for NEAR Protocol which stores keys in browser's localStorage
https://wallet.near.org
MIT License
220 stars 176 forks source link

Large js gets redownloaded on reopening the page #1316

Closed ilblackdragon closed 3 years ago

ilblackdragon commented 3 years ago

Currently on almost every load of the page, 700kb+ of JS gets redownloaded. On not very fast internet Wallet can take up to 15s to load (google.com loads in 4s), reloading another ~5-10s

Screen Shot 2020-12-22 at 5 46 06 PM

From China it's even worse:

Screen Shot 2020-12-22 at 5 50 19 PM

Steps to reproduce

  1. Open incognito window
  2. Open Inspect > "Network" tab
  3. Open wallet.near.org
  4. Observe loading >1Mb of data
  5. Refresh wallet.near.org
  6. Observer re-loading >1Mb of the same data
vgrichina commented 3 years ago

700k of JS is not a lot these days, e.g. Twitter loads more than 1 MB of JS.

Currently on almost every load of the page

this isn't the case for me in either Safari or Chrome. It has etag so any browser properly supporting HTTP shouldn't be re-downloading whole file unless it is updated

maybe it is somehow messed with by firewall though? (not clear how without removing HTTPS)

are you sure it happens outside of incognito (which has to reload everything as otherwise you are identifiable)?

stefanopepe commented 3 years ago

I will embed this one in #1101 , even if not strictly connected I believe that having a smaller payload is better than just pumping everything through CDNs cc @MaximusHaximus

think-in-universe commented 3 years ago

The JS files are not re-downloaded in my test.

The 800+ KB JS file is fast to load in my environment, but still takes 20~40 seconds for some users.

image