search

near / near-wallet

Web wallet for NEAR Protocol which stores keys in browser's localStorage
https://wallet.near.org
MIT License
214 stars 174 forks source link

Show what to expect on Ledger screen #1898

Open ilblackdragon opened 3 years ago

ilblackdragon commented 3 years ago

Currently after clicking on "Approve" for transaction, a screen is shown saying "Approve operation" but it doesn't show any info about the operation itself. Given most of the times the set of actions that user approves are under the wrap in more information - the info that Ledger shows end up pretty much unexpected and un-useful to user.

It make sense in the "Approve operation on the device" pop up to show more information that user should expect on the Ledger - for them to double confirm that there is no "man in the middle".

stefanopepe commented 3 years ago

Assigning this one to @corwinharrell so he can ask a few questions. Do you have a screenshot or a step-by-step process we can use to reproduce the experience? It's not 100% clear if the issue needs to be solved also on the Ledger screen, or it's simply a wallet-side improvement

heycorwin commented 3 years ago

In general, the implementation of the ledger workflow is suboptimal, and I agree that the primary issue is insufficient feedback for the user as they perform each action. Happy to work towards some improvements here 👍

stefanopepe commented 3 years ago

Ping me on Figma when ready for review =)