Improve error handling

[vgrichina]

Need to do fine-grained error handling once https://github.com/nearprotocol/nearcore/issues/1839 lands.

[kcole16]

@vgrichina @marcinbodnar nearprotocol/nearcore#1839 is now merged

[vgrichina]

@kcole16 it's not live yet.

[kcole16]

@vgrichina Re: your comments on Notion

I think it's counterproductive to list all possible errors. Instead it makes sense to start from what user can do in case of failure and distinguish recoverable / unrecoverable errors for given action.

How about determining the potential error states for these three categories, and what the user should do for each (as opposed to each action)?

• HTTP errors
• RPC errors
  • e.g. TX failed
• Client-side errors

[kcole16]

Adding more detail to the above:

• HTTP errors
  • 404
    • Redirect to home
  • 500
    • If error message: Display error
    • If not: "Something went wrong. Please try again!"
  • 400
    • If error message: Display error. e.g. #95
    • If not: Display "You may have entered something incorrectly. Please try again!"
• RPC errors
  • TX failed
    • Out-of-gas error: Resend with more gas?
    • Contract error: Redirect to app
  • RPC timed out
    • Check if TX succeeded
      • Yes: Redirect to success page
      • No: Display "The network may be running a bit slow. Please try again!"

Thoughts? @vgrichina @Patrick1904 @marcinbodnar @corwinharrell

[marcinbodnar]

I gather some possible situations that are not handled, regarding user experience:

Create Account:

• if you enter one char accountId, submit button is active and after click it shows that username is taken (issue #95)
• situation when user enters incorrect char in accountId field, at this moment we are blocking that char, but don't display any information

Protect your Account:

• if the user enters wrong email or phone number, we can display some sort of info, red frame for input field might be enough?

Send Money:

• we should inform user when there is no money to Send - at this moment we are limiting to 5 decimal digits, so we can check if there is enough money at component mount
• if user enters Send Money link with wrong username in URL we are showing info but user name field can be filled: https://wallet.nearprotocol.com/send-money/marcinx

Login:

• if there is no account, and we are redirecting user to Create Account page we can inform him that he will be redirected to Login page after account will be created
• we are checking if contract_id is correct, but we should also check if it's in URL / Session Storage (maybe also checking other necessary parameters): https://wallet.nearprotocol.com/login

Reset Account:

• we are handling it in #443

No network:

• maybe we should inform user that he lost internet connection, now it only appears in the console - it might be a problem because in many cases user can click submit buttons and will just stay on the same page without info, or enter some pages without noticing.

[bowenwang1996]

@kcole16 if rpc times out it is better to first check if the transaction is still valid to avoid sending double the amount of tokens for example.

[ilblackdragon]

I'm curious what is the status here?

I understand there are unstructured errors from nearcore, but for structured errors that are coming from runtime - can we show them to the user?

Because we still just showing "username is taken" even when contract for linkdrop has failed for example.

[vgrichina]

@ilblackdragon this is largely one by one implementation for different part of wallet. Some errors have specific handling, some still don't.